Added missing second param to postMessage function call #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed "Uncaught TypeError: Failed to execute 'postMessage' on 'Window': 2 arguments required, but only 1 present." error.
fixed "Uncaught TypeError: Failed to execute 'postMessage' on 'Window': 2 arguments required, but only 1 present." error
Member
|
interesting, when / where did this become a problem? |
Contributor
Author
|
This error was thrown whenever i used Sass.compile() in my project. Like the error says, Window.postMessage requires two params. So I added the '*' as a second parameter wherever postMessage is called. When I have some time, I can try to reproduce the bug in a jsfiddle |
Member
|
thank you! |
Member
|
I'm not sure why this slipped through. Neither of us realized that Worker.postMessage() does not have an origin, that's only relevant to Window.postMessage(). Your PR actually breaks the Sass.js worker API. I'll have to revert this commit… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added '*' as second parameter to function calls postMessage
This fixes the error